Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: install failing due to chrome driver and out of date lock files #1851

Closed
davidmenendez opened this issue Feb 22, 2024 · 3 comments
Closed

Comments

@davidmenendez
Copy link

davidmenendez commented Feb 22, 2024

Project

accessibility-checker-extension

Browser

Chrome

Operating system

MacOS

Description

in a recent update to chromedriver the URL for their CDN changed. This was fixed in v122.0.1

this repo appears to be using * in package.json for chromedriver. i'd recommend setting a specific version of that and also updating the lock files because currently they are pointing to v119

Steps to reproduce

npm i

@tombrunet
Copy link
Member

We have a .npmrc with detect_chromedriver_version=true. This aligns chromedriver to the version of Chrome that you are using locally. See https://www.npmjs.com/package/chromedriver#detect-chromedriver-version

@tombrunet
Copy link
Member

Talked a bit offline. This is related to the accessibility-checker package (not the accessibility-checker-extension package referenced). Their project had run yarn install earlier and checked in a lock file containing an older chromedriver. The accessibility-checker does not include its own lock file.

Due to the chromedriver issue mentioned in giggio/node-chromedriver#451 , the detect-chromedriver-version mechanism was failing.

This is remedied by clearing the project lock file and installing fresh to pull the latest chromedriver.

@davidmenendez
Copy link
Author

thank you for clarifying everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants