Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel*Distances: Fix multiple keys #201

Closed
yannikschaelte opened this issue Oct 23, 2019 · 2 comments
Closed

Kernel*Distances: Fix multiple keys #201

yannikschaelte opened this issue Oct 23, 2019 · 2 comments
Assignees

Comments

@yannikschaelte
Copy link
Member

Currently, some use the mean argument wrongly, and set the dimension incorrectly. E.g. for IndependentNormalKernel, the variances should be initialized for each key separately, e.g. something like

var = {'s0': np.array([1,1,1]), 's1': np.array([1,1])}
@yannikschaelte yannikschaelte added this to the StochasticAcceptor milestone Oct 23, 2019
@yannikschaelte
Copy link
Member Author

otherwise we have wrong normalizations. this did not affect the anylsis in the past, but nonetheless is wrong and easy to misuse.

@yannikschaelte
Copy link
Member Author

done in #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant