Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote gets removed when user disconnects #73

Open
hyjk2000 opened this issue Jul 24, 2019 · 0 comments
Open

Vote gets removed when user disconnects #73

hyjk2000 opened this issue Jul 24, 2019 · 0 comments

Comments

@hyjk2000
Copy link
Member

Since a large portion of our user base is on mobile devices which would sleep and disconnect from WebSocket, we should handle disconnections gracefully when the user already has a vote on screen. Instead of removing disconnected user from the room and clear their vote, it's better to defer the cleanup until the votes are cleared so votes are kept on screen even after the user is disconnected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant