Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

New player controler #60

Closed
adlzanchetta opened this issue Aug 28, 2020 · 6 comments
Closed

New player controler #60

adlzanchetta opened this issue Aug 28, 2020 · 6 comments

Comments

@adlzanchetta
Copy link
Contributor

Hi,
I am developing a new controller for playing/pausing multi-layer geotiffs. The initial motivation is to display "animated" precipitation products, but it certainly can be used for other purposes. I would like to ask what you all think about including this controller to the main project repository - i.e.: does it fit the scope of the project? could it be useful?

It can be accessed here (takes a few seconds to load - probably I should use a smaller tiff file).

If you find it is considered useful and of general interest, I would be glad to PR it when I have it in a more stable and customizable state (and would also include a nice gif example for the main README.md).

PS: I am just starting to contribute to open source projects. I apologize if this (opening an issue) is not the appropriate way to suggest new features.

@Pedrazl
Copy link
Member

Pedrazl commented Aug 31, 2020

Hi @adlzanchetta ,
this contribution would be great!
For this type of time control, internally we use the excelent TimeDimension plugin created by SOCIB: https://github.com/socib/Leaflet.TimeDimension, have a look, maybe you can find interesting examples.
Anyway, feel free to PR your control and we will integrate it in our plugin.
Thank you!

@adlzanchetta
Copy link
Contributor Author

@Pedrazl ,
Thank you for talking about the TimeDimension plugin. I was not aware of it.
Indeed the TimeDimension looks great and is in a way more mature state than the controller I am bringing in. I need to explore it better.
Maybe we could include an example with its usage as part of the docs. Or maybe it would include an external dependency that start exceeding the scope of the project...?
Anyway, I just performed the PR with the player controller that can be used as a "bulti-in, example included" alternative to the TimeDimension one.

@Pedrazl
Copy link
Member

Pedrazl commented Sep 4, 2020

Perfect! I'll merge the PR next week, thanks.
About the integration of TimeDimension examples, definitely we`ll do in the future.

@Pedrazl Pedrazl closed this as completed Sep 4, 2020
@rmarzocchi84
Copy link

I see the PR but it is not merged: #61

I am interested using the player because I test it with using https://github.com/Eclipse1979/leaflet-slider but it doesn't work (issue #41)

Concerning TimeDimension it is possible to use with Leaflet.CanvasLayer.Field? I only see example with time WMS

@adlzanchetta
Copy link
Contributor Author

adlzanchetta commented Nov 5, 2020

@rmarzocchi84
If you find issues using the player, please let me know.
I would be interested on having an user feedback.

@Pedrazl
Copy link
Member

Pedrazl commented Nov 5, 2020

Merged today :)
Sorry for the delay @adlzanchetta . Thanks again for the contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants