Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OrthographicCamera #6

Closed
vincentmarchetti opened this issue May 24, 2024 · 3 comments
Closed

Implement OrthographicCamera #6

vincentmarchetti opened this issue May 24, 2024 · 3 comments

Comments

@vincentmarchetti
Copy link

the manifesto code currently (at commit e71da4c , 24 May 2024) implements the PerspectiveCamera.

The OrthographicCamera is to be implemented as well.

These two camera types are defined in the draft 3d api at https://github.com/IIIF/3d/blob/main/temp-draft-4.md#cameras

The OrthographicCamera has a position as clarified in discussion: IIIF/api#2288

The fieldOfView of an OrthographicCamera is a linear dimension shown marking the vertical linear distance between top and bottom of the view. See issue IIIF/api#2289

@vincentmarchetti
Copy link
Author

Has been implemented in the kshell-dev branch. I am waiting for the npm deployment to be enabled on the main branch, then will merge orthographic camera through a pull request.

@vincentmarchetti
Copy link
Author

the kshell-dev based pull request conflicted with npm deployment.
A new pull request with an OrthographicCamera implementation is at #9
awaiting review and fast-forward merge.

After this is done both kshell-dev and ortho-camera-pullreq branches will be deleted

@vincentmarchetti
Copy link
Author

Pull request merged
kshell-dev and ortho-camera-pullreq branches deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant