Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate formatting of "note" blocks in specifications #2138

Open
zimeon opened this issue Jun 9, 2022 · 4 comments
Open

Reinstate formatting of "note" blocks in specifications #2138

zimeon opened this issue Jun 9, 2022 · 4 comments

Comments

@zimeon
Copy link
Member

zimeon commented Jun 9, 2022

The IIIF specifications use warning blocks (marked {: .warning} in the source) which appear with a red bar and background, e.g. the "Incompatibility Warning" in https://iiif.io/api/presentation/3.0/#55-annotation-page

The Auth spec uses and alert block (marked {: .alert} in the source) which appears with a yellow bar and background, see https://iiif.io/api/auth/1.0/ before "Introduction"

The Presentation spec uses note blocks (marked {: .note} in the source) which used to appear with a colored bar and background (was it green or yellow?). These blocks are currently not styled in way that makes their meaning clear or calls them out. See:

Possible solutions:

  1. Make {: .note} work again
  2. Change prezi source to use {: .alert}
@zimeon
Copy link
Member Author

zimeon commented Jun 9, 2022

@glenrobson - interested in your thoughts on this

@hadro
Copy link
Contributor

hadro commented Jun 9, 2022

The new theme makes use of Bulma, so it may just be a matter of connecting old properties to the bulma properties: https://bulma.io/documentation/elements/notification/

hadro added a commit that referenced this issue Jun 10, 2022
@hadro
Copy link
Contributor

hadro commented Jun 10, 2022

@hadro
Copy link
Contributor

hadro commented Jun 10, 2022

If all looks fine, maybe you all can merge in #2147 while you're still together...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants