From 598a749751754985cfe696958474b9b4307140ee Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 12:46:38 -0500 Subject: [PATCH 01/15] Add docs/developers-release-checklist.md --- docs/developers-release-checklist.md | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 docs/developers-release-checklist.md diff --git a/docs/developers-release-checklist.md b/docs/developers-release-checklist.md new file mode 100644 index 0000000..c5ec78d --- /dev/null +++ b/docs/developers-release-checklist.md @@ -0,0 +1,28 @@ +# Release checklist + +See also https://github.com/INN/docs/blob/master/projects/wordpress-plugins/release.sh.md + +## Testing before release: + +Plugin settings: + +- [ ] Does the settings page work? + +Frontend tests: +- [ ] `window.dfw` contains`dfpID` and `network_code`, which are the same value, which is that of `get_option('dfw_network_code')` +- [ ] a filter modifying `dfw_js_data` has its modifications output in the frontend `window.dfw` object + +Widget tests + +- [ ] A widget's breakpoints are reflected in the widget's corresponding `mapping*` entry in `window.dfw` +- [ ] A widget outputs its HTML, and the widget's settings are added to `window.dfw` +- [ ] An `[ad number=1]` or `[ad number=2]` shortcode should display the relevant sidebar. +- [ ] An `[ad number=2 align=left]` shortcode should have the class `alignleft`. + +Gutenberg tests + +- [ ] the block, when inserted, has controls +- [ ] the block renders on the frontend as a widget does +- [ ] on a site with Gutenberg not installed, the plugin functions +- [ ] on a 4.9 site with Gutenberg installed, the plugin functions +- [ ] on a 5.0 site, the plugin functions From f5393420ae3429268cfdacab9d3444da8e4f73b8 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 12:47:08 -0500 Subject: [PATCH 02/15] Improve historical note in readme.md for GitHub users. --- readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme.md b/readme.md index 3b06186..a31a222 100644 --- a/readme.md +++ b/readme.md @@ -4,4 +4,4 @@ Serve DoubleClick ads natively in WordPress. Built to make serving responsive ad [Read the documentation on GitHub](https://github.com/INN/DoubleClick-for-WordPress/tree/master/docs). -This plugin was named "DoubleClick for WordPress" [until](https://github.com/inn/doubleclick-for-wp/issues/69) Google [renamed DoubleClick for Publishers to Google Ad Manager](https://www.blog.google/products/admanager/introducing-google-ad-manager/). +This plugin was named "DoubleClick for WordPress" [until](https://github.com/inn/doubleclick-for-wp/issues/69) Google [renamed DoubleClick for Publishers to Google Ad Manager](https://www.blog.google/products/admanager/introducing-google-ad-manager/). That's why this GitHub repo is named `INN/doubleclick-for-wp`. From 9947da1b66f085b7b42658734f8ef57f90b29c41 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 12:47:49 -0500 Subject: [PATCH 03/15] Add contribution info to plugin readme.txt --- readme.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/readme.txt b/readme.txt index b10ad91..d7f6cfa 100644 --- a/readme.txt +++ b/readme.txt @@ -18,6 +18,8 @@ Implementing is simple. Configure your network code and input your identifiers. For more advanced documentation for developers and advanced users see [the official plugin docs](https://github.com/INN/DoubleClick-for-WordPress/blob/master/docs/readme.md). +To contribute to this plugin, please [visit it on GitHub](https://github.com/INN/doubleclick-for-wp/issues), or send us an email at [support@inn.org](mailto:support@inn.org). + == Installation == From 8da7c593e2b458d4cceaa205a81c42f17650e064 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 12:48:12 -0500 Subject: [PATCH 04/15] Update changelog for 0.3 --- readme.txt | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/readme.txt b/readme.txt index d7f6cfa..72fbc7a 100644 --- a/readme.txt +++ b/readme.txt @@ -35,20 +35,31 @@ For more advanced documentation for developers and advanced users see [the offic = 0.3 = -Thanks to WordPress.org user [onlineforbusiness](https://wordpress.org/support/users/onlineforbusiness/) and GitHub user [dbeniaminov](https://github.com/dbeniaminov) for their contributions to this release. +Thanks to WordPress.org user [onlineforbusiness](https://wordpress.org/support/users/onlineforbusiness/) and GitHub users [dbeniaminov](https://github.com/dbeniaminov) and [tienvooracht](https://github.com/tienvooracht) for their contributions to this release. + +New features: + +- Adds a Gutenberg Block for manual insertion of ads in posts. [Pull request #82](https://github.com/INN/doubleclick-for-wp/pull/82) for [issue #70](https://github.com/INN/doubleclick-for-wp/issues/70). +- Adds a PHP filter `'dfw_js_data'`, to allow modification of the `window.dfw` object before it's output on the page. Refactors widgets and blocks to draw all details needed from `window.dfw` instead of separately-enqueued JSON blobs. This should allow you to `setRequestNonPersonalizedAds. [PR #81](https://github.com/INN/doubleclick-for-wp/pull/81) for [issue #63](https://github.com/INN/doubleclick-for-wp/issues/63), with thanks to GitHub user [tienvooracht](https://github.com/tienvooracht) for the idea. + +Changes and fixes: - Rebrands from "DoubleClick for WordPress" to "Super Cool Ad Manager Plugin", because [Google merged DoubleClick for Publishers into Google Ad Manager](https://www.blog.google/products/admanager/introducing-google-ad-manager/). - Updates to `jquery.dfp.js` version 2.4.2, adding `setCentering` support. [PR #67](https://github.com/INN/doubleclick-for-wp/pull/67) for [issue #66](https://github.com/INN/doubleclick-for-wp/issues/66) -- Removes 'single' page targeting from post-type archives and from static front pages. [PR #72](https://github.com/INN/doubleclick-for-wp/pull/72) for [issue #61](https://github.com/INN/doubleclick-for-wp/issues/61), thanks to GitHub user [dbeniaminov](https://github.com/dbeniaminov). - Adds "Category" targeting on category archive. [PR #72](https://github.com/INN/doubleclick-for-wp/pull/72) for [issue #61](https://github.com/INN/doubleclick-for-wp/issues/61). - Adds "Tag" targeting on tag archive. [PR #74](https://github.com/INN/doubleclick-for-wp/pull/74) for [issue #29](https://github.com/INN/doubleclick-for-wp/issues/29). - Fixes a number of PHP warnings and errors, including [issue #8](https://github.com/INN/doubleclick-for-wp/issues/8) and [issue #37](https://github.com/INN/doubleclick-for-wp/issues/37) in [PR #76](https://github.com/INN/doubleclick-for-wp/pull/76) and [issue #31](https://github.com/INN/doubleclick-for-wp/issues/31) in [PR #80](https://github.com/INN/doubleclick-for-wp/pull/80/). - Fixes a targeting problem that occurred when wp_footer ran outside The Loop. ([PR #87](https://github.com/INN/doubleclick-for-wp/pull/87) for [this support topic](https://wordpress.org/support/topic/categories-tags-bug-and-solution/).) + +Documentation updates: + - Adds "Ad unit" label to widget settings for the "Identifier" setting, to match Google's language. [PR #73](https://github.com/INN/doubleclick-for-wp/pull/73) for [issue #26](https://github.com/INN/doubleclick-for-wp/issues/26). - Adds GitHub Pull Request template and Contributing guidelines files. - Adds a plugin text domain: `dfw`. ([PR #76](https://github.com/INN/doubleclick-for-wp/pull/76)) - Adds the GPL2 license to the plugin header; this plugin has been GPL2 since 2015 but that wasn't marked in a WordPress-accessible way. ([PR #76](https://github.com/INN/doubleclick-for-wp/pull/76)) - Moves the documentation index file from `docs/index.md` to `docs/readme.md` in the GitHub repository, so that the Markdown will display to all who visit [the docs directory](https://github.com/INN/doubleclick-for-wp/tree/master/docs). ([PR #80](https://github.com/INN/doubleclick-for-wp/pull/80)) +- Moves plugin functions and files around within the plugin; see [PR #72](https://github.com/INN/doubleclick-for-wp/pull/81) for details. +- Removes 'single' page targeting from post-type archives and from static front pages. [PR #72](https://github.com/INN/doubleclick-for-wp/pull/72) for [issue #61](https://github.com/INN/doubleclick-for-wp/issues/61), thanks to GitHub user [dbeniaminov](https://github.com/dbeniaminov). = 0.2.1 = From 27ac6d4ba4450f4d5801874963807da184b49359 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 12:48:20 -0500 Subject: [PATCH 05/15] Add upgrade notices. --- readme.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/readme.txt b/readme.txt index 72fbc7a..2e2ede1 100644 --- a/readme.txt +++ b/readme.txt @@ -77,3 +77,8 @@ Documentation updates: - Initial beta release. - Add support for displaying different sizes of ad unit based on the size of the viewport +== Upgrade Notice == + += 0.3 = + +This update adds support for direct insertion of ads in posts via Gutenberg, filter-based modificaiton of ad options, and resolves a number of bugs. From a78975e2ee49550b396dded97b8821d37128e862 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 14:09:04 -0500 Subject: [PATCH 06/15] Fix CSS output on block in editor: need the block css class --- js/block.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/block.js b/js/block.js index 5a1ec87..ecc881f 100644 --- a/js/block.js +++ b/js/block.js @@ -54,7 +54,7 @@ alignwide: true, anchor: false, customClassName: true, - className: false, + className: true, inserter: true, multuple: true, }, From 29d3dcec0603690aba0eb7f1b21ebbd3fdc192c0 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 14:09:21 -0500 Subject: [PATCH 07/15] PHP min required: 5.3 --- docs/developers-release-checklist.md | 6 ++++++ readme.txt | 1 + 2 files changed, 7 insertions(+) diff --git a/docs/developers-release-checklist.md b/docs/developers-release-checklist.md index c5ec78d..f765598 100644 --- a/docs/developers-release-checklist.md +++ b/docs/developers-release-checklist.md @@ -9,6 +9,7 @@ Plugin settings: - [ ] Does the settings page work? Frontend tests: + - [ ] `window.dfw` contains`dfpID` and `network_code`, which are the same value, which is that of `get_option('dfw_network_code')` - [ ] a filter modifying `dfw_js_data` has its modifications output in the frontend `window.dfw` object @@ -26,3 +27,8 @@ Gutenberg tests - [ ] on a site with Gutenberg not installed, the plugin functions - [ ] on a 4.9 site with Gutenberg installed, the plugin functions - [ ] on a 5.0 site, the plugin functions + +Plugin metadata: + +- [ ] Does the minimum PHP required version need to be updated in `readme.txt`? +- [ ] Does the WordPress "Tested up to" version need to be updated? Check with [the phpcs PHPCompatibility rules](https://github.com/PHPCompatibility/PHPCompatibility). diff --git a/readme.txt b/readme.txt index 2e2ede1..b9f5b9a 100644 --- a/readme.txt +++ b/readme.txt @@ -3,6 +3,7 @@ Contributors: innlabs, willhaynes24 Donate link: https://inn.org/donate Tags: ads, doubleclick, publishers, news Requires at least: 4.0.0 +Requires PHP: 5.3 Tested up to: 5.0-beta2 Stable tag: 0.2.1 License: GPLv2 or later From 89d9aef018ee2c8cc5187cbf36a2924689a492f2 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 14:09:40 -0500 Subject: [PATCH 08/15] Tested up to: 5.0-beta3 --- readme.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme.txt b/readme.txt index b9f5b9a..a9b3ce3 100644 --- a/readme.txt +++ b/readme.txt @@ -4,7 +4,7 @@ Donate link: https://inn.org/donate Tags: ads, doubleclick, publishers, news Requires at least: 4.0.0 Requires PHP: 5.3 -Tested up to: 5.0-beta2 +Tested up to: 5.0-beta3 Stable tag: 0.2.1 License: GPLv2 or later License URI: http://www.gnu.org/licenses/gpl-2.0.html From e044db97ed0143d34dd1ae5d9df5d81a7f8e6567 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 14:11:31 -0500 Subject: [PATCH 09/15] Bump version number to 0.3 --- bower.json | 2 +- dfw.php | 4 ++-- readme.txt | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/bower.json b/bower.json index 6374956..047c269 100644 --- a/bower.json +++ b/bower.json @@ -1,6 +1,6 @@ { "name": "dfp", - "version": "0.2.1", + "version": "0.3", "homepage": "https://github.com/INN/DoubleClick-for-WordPress", "authors": [ "nerds@inn.org" diff --git a/dfw.php b/dfw.php index bfade1a..272ce9f 100644 --- a/dfw.php +++ b/dfw.php @@ -2,7 +2,7 @@ /* Plugin Name: DoubleClick for WordPress Description: A simple way to serve DoubleClick ads in WordPress. -Version: 0.2 +Version: 0.3 Author: innlabs, Will Haynes for INN Author URI: https://labs.inn.org/ License: GPL Version 2 or later @@ -10,7 +10,7 @@ Text Domain: dfw */ -define( 'DFP_VERSION', '0.2.0' ); +define( 'DFP_VERSION', '0.3.0' ); $includes = array( '/inc/class-doubleclick.php', diff --git a/readme.txt b/readme.txt index a9b3ce3..028b10a 100644 --- a/readme.txt +++ b/readme.txt @@ -5,7 +5,7 @@ Tags: ads, doubleclick, publishers, news Requires at least: 4.0.0 Requires PHP: 5.3 Tested up to: 5.0-beta3 -Stable tag: 0.2.1 +Stable tag: 0.3 License: GPLv2 or later License URI: http://www.gnu.org/licenses/gpl-2.0.html @@ -42,6 +42,7 @@ New features: - Adds a Gutenberg Block for manual insertion of ads in posts. [Pull request #82](https://github.com/INN/doubleclick-for-wp/pull/82) for [issue #70](https://github.com/INN/doubleclick-for-wp/issues/70). - Adds a PHP filter `'dfw_js_data'`, to allow modification of the `window.dfw` object before it's output on the page. Refactors widgets and blocks to draw all details needed from `window.dfw` instead of separately-enqueued JSON blobs. This should allow you to `setRequestNonPersonalizedAds. [PR #81](https://github.com/INN/doubleclick-for-wp/pull/81) for [issue #63](https://github.com/INN/doubleclick-for-wp/issues/63), with thanks to GitHub user [tienvooracht](https://github.com/tienvooracht) for the idea. +- Tested up to WordPress 5.0-beta3 Changes and fixes: From 4a9babd382bfdb1095bbc7e8638ffd507ac902d7 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 14:15:15 -0500 Subject: [PATCH 10/15] Add some @since 0.3 tags --- inc/block.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/inc/block.php b/inc/block.php index 8049deb..f95bfeb 100644 --- a/inc/block.php +++ b/inc/block.php @@ -9,6 +9,7 @@ * Register all block assets so they can be enqueued through Gutenberg in the corresponding context * * @link https://wordpress.org/gutenberg/handbook/blocks/writing-your-first-block-type/#enqueuing-block-scripts + * @since 0.3 */ function dfw_block_init() { if( ! function_exists( 'register_block_type' ) ) { @@ -109,6 +110,7 @@ function dfw_block_init() { * - provide classes * * @param Array $args The widget/thing arguments + * @since 0.3 */ function dfw_block_render_callback( $instance=array(), $content='', $tag='' ) { /* From e8eda674bbd64cd27bd65cf6c8da089c6877f212 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 15:14:38 -0500 Subject: [PATCH 11/15] More potentially-breaking notes in 0.3 readme/update notes. --- readme.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/readme.txt b/readme.txt index 028b10a..d1b720a 100644 --- a/readme.txt +++ b/readme.txt @@ -47,6 +47,7 @@ New features: Changes and fixes: - Rebrands from "DoubleClick for WordPress" to "Super Cool Ad Manager Plugin", because [Google merged DoubleClick for Publishers into Google Ad Manager](https://www.blog.google/products/admanager/introducing-google-ad-manager/). +- **Potentially-breaking changes**: Renames a number of varibles from `camelCase` to `snake_case` in [pull request #46](https://github.com/INN/doubleclick-for-wp/pull/46) for Wordpress.com VIP compatibility. This includes renaming the global variable `$DoubleClick` to `$doubleclick`, and many of its properties from `$DoubleClick->camelCase` to `$doubleclick->snake_case`. If you modify this plugin's features via filters or actions, or if you call this plugin's functions and methods directly from your code, - Updates to `jquery.dfp.js` version 2.4.2, adding `setCentering` support. [PR #67](https://github.com/INN/doubleclick-for-wp/pull/67) for [issue #66](https://github.com/INN/doubleclick-for-wp/issues/66) - Adds "Category" targeting on category archive. [PR #72](https://github.com/INN/doubleclick-for-wp/pull/72) for [issue #61](https://github.com/INN/doubleclick-for-wp/issues/61). - Adds "Tag" targeting on tag archive. [PR #74](https://github.com/INN/doubleclick-for-wp/pull/74) for [issue #29](https://github.com/INN/doubleclick-for-wp/issues/29). @@ -84,3 +85,5 @@ Documentation updates: = 0.3 = This update adds support for direct insertion of ads in posts via Gutenberg, filter-based modificaiton of ad options, and resolves a number of bugs. + +This update renames the global variable `$DoubleClick` to `$doubleclick`, along with many of that class's properties. If you modify this plugin's functionality via filters or custom functionality, check your code before deploying to production. From 08f1245f006a529925dbc7c3d445d1929578936d Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 15:15:03 -0500 Subject: [PATCH 12/15] Notes for future devs regarding backwards compatibility --- docs/developers-release-checklist.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/developers-release-checklist.md b/docs/developers-release-checklist.md index f765598..d92fe33 100644 --- a/docs/developers-release-checklist.md +++ b/docs/developers-release-checklist.md @@ -7,6 +7,7 @@ See also https://github.com/INN/docs/blob/master/projects/wordpress-plugins/rele Plugin settings: - [ ] Does the settings page work? +- [ ] Do settings saved in a previous version of this plugin work? Frontend tests: @@ -19,6 +20,7 @@ Widget tests - [ ] A widget outputs its HTML, and the widget's settings are added to `window.dfw` - [ ] An `[ad number=1]` or `[ad number=2]` shortcode should display the relevant sidebar. - [ ] An `[ad number=2 align=left]` shortcode should have the class `alignleft`. +- [ ] Do settings saved in a previous version of this plugin work? Gutenberg tests @@ -27,6 +29,7 @@ Gutenberg tests - [ ] on a site with Gutenberg not installed, the plugin functions - [ ] on a 4.9 site with Gutenberg installed, the plugin functions - [ ] on a 5.0 site, the plugin functions +- [ ] Do settings saved in a previous version of this plugin work? Plugin metadata: From 5aa21080859a7555275e322e84e7eea6d736b667 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 15:22:23 -0500 Subject: [PATCH 13/15] improve backwards-compatibility support after changes made in https://github.com/INN/doubleclick-for-wp/pull/46 --- dfw-options.php | 20 +++++++++++++++++++- docs/Developer-API.md | 2 +- inc/class-doubleclickbreakpoint.php | 18 +++++++++--------- 3 files changed, 29 insertions(+), 11 deletions(-) diff --git a/dfw-options.php b/dfw-options.php index c59d43e..f4b49de 100644 --- a/dfw-options.php +++ b/dfw-options.php @@ -143,7 +143,25 @@ function dfw_breakpoints_input() { while ( $i < 5 ) { $identifier = ( isset( $breakpoints[ $i ]['identifier'] ) )? $breakpoints[ $i ]['identifier'] : ''; $min_width = ( isset( $breakpoints[ $i ]['min-width'] ) )? $breakpoints[ $i ]['min-width'] : ''; - $max_width = ( isset( $breakpoints[ $i ]['max-width'] ) )? $breakpoints[ $i ]['max-width'] : ''; ?> + $max_width = ( isset( $breakpoints[ $i ]['max-width'] ) )? $breakpoints[ $i ]['max-width'] : ''; + + // fallbacks for post-https://github.com/INN/doubleclick-for-wp/pull/46 compatibility. + if ( empty( $min_width ) && isset( $breakpoints[ $i ][ 'minWidth' ] ) ) { + $min_width = ( isset( $breakpoints[ $i ]['minWidth'] ) )? $breakpoints[ $i ]['minWidth'] : ''; + } + if ( empty( $max_width ) && isset( $breakpoints[ $i ][ 'maxWidth' ] ) ) { + $max_width = ( isset( $breakpoints[ $i ]['maxWidth'] ) )? $breakpoints[ $i ]['maxWidth'] : ''; + } + + // fallbacks, continued. + if ( empty( $min_width ) && isset( $breakpoints[ $i ][ 'min-width' ] ) ) { + $min_width = ( isset( $breakpoints[ $i ]['min-width'] ) )? $breakpoints[ $i ]['min-width'] : ''; + } + if ( empty( $max_width ) && isset( $breakpoints[ $i ][ 'max-width' ] ) ) { + $max_width = ( isset( $breakpoints[ $i ]['max-width'] ) )? $breakpoints[ $i ]['max-width'] : ''; + } + + ?> min_width = $args['min_width']; + } else if ( isset( $args['minWidth'] ) ) { + $this->min_width = $args['minWidth']; + } else if ( isset( $args['min-width'] ) ) { + $this->max_width = $args['min-width']; } if ( isset( $args['max_width'] ) ) { $this->max_width = $args['max_width']; + } else if ( isset( $args['maxWidth'] ) ) { + $this->max_width = $args['maxWidth']; + } else if ( isset( $args['max-width'] ) ) { + $this->max_width = $args['max-width']; } if ( isset( $args['_option'] ) && $args['_option'] ) { $this->option = true; } - - // Same, but with different spelling - if ( isset( $args['max-width'] ) ) { - $this->max_width = $args['max-width']; - } - if ( isset( $args['min-width'] ) ) { - $this->min_width = $args['min-width']; - } - $this->identifier = $identifier; } From 1f7e4f627ba73968ddff5bbe2cf9625c07873a01 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 16:03:43 -0500 Subject: [PATCH 14/15] Clean up dev docs --- ...developers-release-checklist.md => dev-release-checklist.md} | 2 ++ docs/{dev-updates.md => dev-update-dependencies.md} | 0 2 files changed, 2 insertions(+) rename docs/{developers-release-checklist.md => dev-release-checklist.md} (92%) rename docs/{dev-updates.md => dev-update-dependencies.md} (100%) diff --git a/docs/developers-release-checklist.md b/docs/dev-release-checklist.md similarity index 92% rename from docs/developers-release-checklist.md rename to docs/dev-release-checklist.md index d92fe33..50b5eeb 100644 --- a/docs/developers-release-checklist.md +++ b/docs/dev-release-checklist.md @@ -2,6 +2,8 @@ See also https://github.com/INN/docs/blob/master/projects/wordpress-plugins/release.sh.md +- [ ] Are we on the latest version of `jquery.dfp.js`? See [related docs for updating that dependency](./dev-update-dependencies.md) + ## Testing before release: Plugin settings: diff --git a/docs/dev-updates.md b/docs/dev-update-dependencies.md similarity index 100% rename from docs/dev-updates.md rename to docs/dev-update-dependencies.md From bd2d2a3f10861ec4a5279fc6b828ae16195dc7a8 Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 6 Nov 2018 16:05:30 -0500 Subject: [PATCH 15/15] Remove some lines copied from SCAIP in the release checklist that do not apply to this plugin --- docs/dev-release-checklist.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/dev-release-checklist.md b/docs/dev-release-checklist.md index 50b5eeb..041a768 100644 --- a/docs/dev-release-checklist.md +++ b/docs/dev-release-checklist.md @@ -20,8 +20,6 @@ Widget tests - [ ] A widget's breakpoints are reflected in the widget's corresponding `mapping*` entry in `window.dfw` - [ ] A widget outputs its HTML, and the widget's settings are added to `window.dfw` -- [ ] An `[ad number=1]` or `[ad number=2]` shortcode should display the relevant sidebar. -- [ ] An `[ad number=2 align=left]` shortcode should have the class `alignleft`. - [ ] Do settings saved in a previous version of this plugin work? Gutenberg tests