You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The preview codebase uses gitlab as backend for fulfilling features on library and digital twins preview pages. This code does not yet follow SOLID principles and has some code quality issues.
As a first step the core gitlab interface needs to be brought out into the stable codebase.
Describe the solution you'd like
The following code needs to be brought out into stable codebase.
Move the required redux slices to src/model/backend/gitlab/store
Describe alternatives you've considered
Ideally, I would like to limit the work to the following files.
gitlab.ts
DigitalTwin.ts
DigitalTwinUtils.ts
Constants
But that would require serious splitting of existing preview code. If there is a way to accomplish the task of refactoring the above four files, that would be preferable.
Success Criterion
Checklist:
Existing preview features remains intact
Code and tests are successfully migrated
Code is refactored as per SOLID principles
Test coverage remains the same
Codeclimate issues are resolved
The text was updated successfully, but these errors were encountered:
Describe the feature
As a developer I want to integrate gitlab codebase into stable codebase So That the code quality gets improved.
Describe the problems your feature request solves
The preview codebase uses gitlab as backend for fulfilling features on library and digital twins preview pages. This code does not yet follow SOLID principles and has some code quality issues.
As a first step the core gitlab interface needs to be brought out into the stable codebase.
Describe the solution you'd like
The following code needs to be brought out into stable codebase.
src/model/definitions/asset.ts
Imported into and re-exported in
src/model/api.ts
src/model/backend/gitlab
src/model/backend/gitlab/constants.ts
src/model/backend/gitlab/store
Describe alternatives you've considered
Ideally, I would like to limit the work to the following files.
But that would require serious splitting of existing preview code. If there is a way to accomplish the task of refactoring the above four files, that would be preferable.
Success Criterion
Checklist:
The text was updated successfully, but these errors were encountered: