Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker installation files #748

Closed
prasadtalasila opened this issue May 8, 2024 · 4 comments
Closed

Improve docker installation files #748

prasadtalasila opened this issue May 8, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@prasadtalasila
Copy link
Contributor

prasadtalasila commented May 8, 2024

The .env file has the following format:

DTAAS_DIR='/User/xxx/DTaaS'
SERVER_DNS='foo.com'
OAUTH_URL='http://foo.com/gitlab'
CLIENT_ID='xxx'
CLIENT_SECRET='xxx'
OAUTH_SECRET='random-secret-string'
CLIENT_CONFIG='/User/xxx/DTaaS/deploy/config/client/env.trial.js'
username1='user1'
username2='user2'

While the names of CLIENT_ID and CLIENT_SECRET are technically correct from OAuth providers point of view, they are confusing to the admin of DTaaS. From admin's point of view, these are variables for traefik forward-auth and probably renamed to OAUTH_CLIENT_ID and OAUTH_CLIENT_SECRET. Thus the suggested configuration is

DTAAS_DIR='/User/xxx/DTaaS'
SERVER_DNS='foo.com/gitlab'
OAUTH_URL='http://foo.com'
OAUTH_CLIENT_ID='xxx'
OAUTH_CLIENT_SECRET='xxx'
OAUTH_SECRET='random-secret-string'
CLIENT_CONFIG='/User/xxx/DTaaS/deploy/config/client/env.trial.js'
username1='user1'
username2='user2'
@prasadtalasila prasadtalasila added enhancement New feature or request good first issue Good for newcomers labels May 8, 2024
@prasadtalasila
Copy link
Contributor Author

It is also better to rename deploy/config/lib.docker to just deploy/config/lib

@prasadtalasila prasadtalasila added this to the Release v0.6.0 milestone Jun 19, 2024
@prasadtalasila
Copy link
Contributor Author

Add debug log level to traefik and traefik-forward-auth containers.

@prasadtalasila
Copy link
Contributor Author

Remove version tag from docker compose field and follow any recent best practices about structuring of docker compose files.

@prasadtalasila prasadtalasila changed the title Rename variables in docker installation Improve docker installation files Sep 19, 2024
@prasadtalasila prasadtalasila modified the milestone: Release v0.6.0 Oct 8, 2024
@prasadtalasila
Copy link
Contributor Author

completed in PR #988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

1 participant