Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threaded Web API test passes although Web server fails to start #240

Open
FrederikPM opened this issue May 10, 2021 · 5 comments
Open

Threaded Web API test passes although Web server fails to start #240

FrederikPM opened this issue May 10, 2021 · 5 comments

Comments

@FrederikPM
Copy link
Collaborator

The test Threaded Web API test executed by the test_simultaneous_simulations.py script as part of the github actions workflow passes although it states that the test fails to start the web server with the following description: "Web server failed to start. Port 8082 was already in use.".

@FrederikPM
Copy link
Collaborator Author

FrederikPM commented May 10, 2021

@maxs-rose can you look into this?

@maxs-rose
Copy link
Contributor

maxs-rose commented May 10, 2021

That occurs when the previous script fails to shutdown maestro. I think its a problem with python being unable to stop Java processes sometimes and I am not entirely sure how to solve it

@FrederikPM
Copy link
Collaborator Author

Ah okay. So it connects to the Maestro instance created by the previous test on port 8082 as it is not shutdown and this is why it passes although the port is in use?
Could a workaround then be to check if the port is in use and if so find a free port for the Maestro intance that is to be instantiated for the test?

@maxs-rose
Copy link
Contributor

I think that could be a workaround. Will have a look into it

@FrederikPM
Copy link
Collaborator Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants