Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display git version for easier identification #108

Open
ronaldtse opened this issue Jun 2, 2020 · 6 comments
Open

Display git version for easier identification #108

ronaldtse opened this issue Jun 2, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link
Collaborator

@phuonghuynh can we display git hash at the footer so we know what version is currently deployed?

@ronaldtse ronaldtse added the enhancement New feature or request label Jun 2, 2020
@maccraymer
Copy link

maccraymer commented Jun 2, 2020 via email

@phuonghuynh
Copy link
Contributor

@ronaldtse @maccraymer yes, already did

Screenshot_3

@ronaldtse
Copy link
Collaborator Author

Thanks @phuonghuynh !

@ronaldtse
Copy link
Collaborator Author

ronaldtse commented Jun 3, 2020

@phuonghuynh but the current production still shows this?
Screen Shot 2020-06-03 at 10 28 12 AM

(The commit hash is accurately at the latest commit, though, so it's only the date shown that is outdated)

@maccraymer
Copy link

The date/time stamp at the bottom every Registry web page was supposed to be the date the database was last updated, not the software version? I thought you were going to add the software revision along with this, not replace it. I think we need to provide a version identifier for both the software and the database. My suggestion is:

Software revision: yyyy-mm-ddThh.mmZ, Database last updated: yyyy-mm-ddThh.mmZ

By the way, does the software have a name? If not, can we give it one in consultation with Florian?

@ronaldtse
Copy link
Collaborator Author

Software revision: yyyy-mm-ddThh.mmZ, Database last updated: yyyy-mm-ddThh.mmZ

Sorry got confused -- this sounds good.

By the way, does the software have a name? If not, can we give it one in consultation with Florian?

Don't think so at the moment. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants