Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Fix Forget Password Endpoint #87

Open
CloudSalander opened this issue Sep 21, 2023 · 1 comment · Fixed by #88
Open

[BE] Fix Forget Password Endpoint #87

CloudSalander opened this issue Sep 21, 2023 · 1 comment · Fixed by #88
Assignees

Comments

@CloudSalander
Copy link
Collaborator

No description provided.

@Edvenan
Copy link
Collaborator

Edvenan commented Sep 21, 2023

Changes:

  • app.php : delete duplicate routes for 'forget password' feature.

  • ForgetController.php: deleted since its only method 'forgetPassword' is duplicated in UserController.php.

  • UserController.php : Updated forgetPassword method

  • Http\Mail\ForgetMail.php : corrected public var $token and added user name var, both to be used inside email content

  • App\Exceptions\Handler.php : added validation error handling to send response containing the message of the error

  • resources/views/mail/forget.blade.php :(1) replaced text 'company name' by 'IT Academy Landing', (2) Added user name after 'Hello', (3) Changed Reset Button alignment from left to center, (4) corrected reset password link to call the right method

  • Renamed file names to make them more understandable:

    • forget.badae.php -> forgetPassword.blade.php
    • forgetMail.php -> forgetPasswordMail.php
  • Http\Requests\ResetRequest.php: updated password rules to match those in store process (register) of UserController.php

Screenshot:

screenshot

@FranEnLaNube FranEnLaNube linked a pull request Nov 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants