Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow syntax observer(; f, g) #19

Closed
mtfishman opened this issue Apr 4, 2024 · 1 comment
Closed

Allow syntax observer(; f, g) #19

mtfishman opened this issue Apr 4, 2024 · 1 comment

Comments

@mtfishman
Copy link
Member

Allow the constructor syntax observer(; f, g), or observer(; f=func_f, g=func_g).

The name of the column will be the name of the keyword argument. I think I didn't do allow this before because currently keyword arguments passed to observer get forwarded to the DataFrame constructor call, however we can disambiguate that with the syntax observer(; f, g, dataframe_kwargs=(; makeunique=false, copycols=true)). This will preclude using dataframe_kwargs as a column name if that syntax is used, which seems like a reasonable compromise. Supported keyword arguments for the DataFrame constructor can be found here: https://dataframes.juliadata.org/stable/lib/types/#DataFrames.DataFrame.

@mtfishman
Copy link
Member Author

Closed by #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant