Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module separation #111

Open
lilgallon opened this issue Jun 19, 2024 · 2 comments
Open

Module separation #111

lilgallon opened this issue Jun 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@lilgallon
Copy link
Member

What is the purpose of having separate ocpi-2-2-1 and ocpi-transport maven dependencies?

ocpi-2-2-1 should include ocpi-transport in its jar. That way, users of the lib will just need to import ocpi-2-2-1 in their project.

Later, we could also provide transport implementations, and it would make sense in that case to create separate jars, because they will be optional (example: ocpi-transport-http4k-impl)

@lilgallon lilgallon added the enhancement New feature or request label Jun 19, 2024
@atschabu
Copy link
Contributor

I guess it made more sense while there was a ocpi 2.1 implementation. It might be relevant again when there is a 3.x implementation. But the relation is not as clear cut, I have far too many "hacks" to get the transport layer work nicely with ocpi module

@lilgallon
Copy link
Member Author

Yes it was made because the transport layer is common for each OCPI version. The thing is that it should not be a separate maven dependency because it's not optional, but mandatory (main ocpi module depends on the transport module)

I am not super satisfied with the way the transport part of ocpi module is designed either. It may change in the future, but it's not the priority at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants