Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Groups show both mandatory "Servicegroup" and optional "Display Name" #1123

Open
thomas-merz opened this issue Jan 7, 2025 · 8 comments

Comments

@thomas-merz
Copy link

Describe the bug

"Service Groups" shows "Name/Servicegroup" and "Display Name" instead of only one of them as in the past.

Expected behavior

"Service Groups" should only show "Name/Servicegroup" if "Display Name" is empty instead of showing both all the time.

Screenshots

Your Environment

About 880 hosts in 42 Service Groups.

  • Icinga Web 2 version and modules (System - About):
Icinga Web 2 Version    2.12.2
Git commit    7f9217b0521f19f770ad59ca17d7d4b3514e54e5
PHP Version    7.3.20
Git commit date    2024-11-13
Loaded Libraries
icinga/icinga-php-library    0.14.1
icinga/icinga-php-thirdparty    0.12.1
Loaded Modules
deployment        2.0.0-beta1
director        1.11.1
dmtech        0.8.2
fileshipper        1.2.0
filiadata        0.0.0
foreman        0.1.0
generictts        2.1.0
icingadb        1.1.2
incubator        0.22.0
migrate        2.12.2
puppetdb        1.0.0
  • Web browser used:
    Something Chrome based but also with Firefox

  • Icinga 2 version used (icinga2 --version):

icinga2 - The Icinga 2 network monitoring daemon (version: r2.14.3-1)

Copyright (c) 2012-2025 Icinga GmbH (https://icinga.com/)
License GPLv2+: GNU GPL version 2 or later <https://gnu.org/licenses/gpl2.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

System information:
  Platform: Red Hat Enterprise Linux
  Platform version: 8.10 (Ootpa)
  Kernel: Linux
  Kernel version: 4.18.0-553.33.1.el8_10.x86_64
  Architecture: x86_64

Build information:
  Compiler: GNU 8.5.0
  Build host: unknown
  OpenSSL version: OpenSSL 1.1.1k  FIPS 25 Mar 2021

Application information:

General paths:
  Config directory: /etc/icinga2
  Data directory: /var/lib/icinga2
  Log directory: /var/log/icinga2
  Cache directory: /var/cache/icinga2
  Spool directory: /var/spool/icinga2
  Run directory: /run/icinga2

Old paths (deprecated):
  Installation root: /usr
  Sysconf directory: /etc
  Run directory (base): /run
  Local state directory: /var

Internal paths:
  Package data directory: /usr/share/icinga2
  State path: /var/lib/icinga2/icinga2.state
  Modified attributes path: /var/lib/icinga2/modified-attributes.conf
  Objects path: /var/cache/icinga2/icinga2.debug
  Vars path: /var/cache/icinga2/icinga2.vars
  PID path: /run/icinga2/icinga2.pid
  • PHP version used (php --version):
PHP 7.3.20 (cli) (built: Jul  7 2020 07:53:49) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.20, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.20, Copyright (c) 1999-2018, by Zend Technologies
  • Server operating system and version:
    Red Hat Enterprise Linux 8.10 (Ootpa)
@thomas-merz
Copy link
Author

Couldn't upload screenshots above, so I dumped them here:
Screenshot 2025-01-07 at 15 04 29
Screenshot 2025-01-07 at 15 04 41

@thomas-merz
Copy link
Author

thomas-merz commented Jan 7, 2025

@dgoetz , FYI!? This seems to have started after we migrated IcingaDB… 🤷🏼‍♂️

@dgoetz
Copy link

dgoetz commented Jan 7, 2025

Request makes totally sense for me as you would set a display name to have it displayed instead, not in addition. And with Icinga 2 being able to use any characters in object names I do not see a use in having a display name instead of the name at all.
But the issue should be moved to https://github.com/Icinga/icingadb-web/issues what someone from the Icinga project should be able to do.

@slalomsk8er
Copy link

@dgoetz The sense in having object names and display names is as follows:
If you rename a object you loose the connection to the history in the time series database but if you change the display name the connection stays.

@thomas-merz
Copy link
Author

@slalomsk8er , that's a nice explanation. But nevertheless is seems pretty useless or at least very redundant to show BOTH. One ("Display Name") should be enough 😄

@dgoetz
Copy link

dgoetz commented Jan 8, 2025

@slalomsk8er Yes, but not for groups (or at least not in the default scenario and most others). And as @thomas-merz says those use cases are not related to displaying both. For hosts I would also say showing both optionally like it is done has its use cases as I have seen environments where the display name of a host was more descriptive while the object name was the real host name, but we are here talking just about groups.

@slalomsk8er
Copy link

True, for groups it doesn't matter.

@sukhwinder33445 sukhwinder33445 transferred this issue from Icinga/icingaweb2 Jan 10, 2025
@slalomsk8er
Copy link

slalomsk8er commented Jan 10, 2025

Maybe having both does also matter for groups as renaming via display name will preserve links.
But showing both makes no sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants