Add retryable connection #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
retryable-conn
branch
2 times, most recently
from
be4e327
to
fad4504
Compare
yhabteab
force-pushed
the
retryable-conn
branch
from
fad4504
to
fb92651
Compare
|
Is this already used somewhere? |
Not yet, but this will replace the |
nilmerg
requested changes
Sep 12, 2023
yhabteab
force-pushed
the
retryable-conn
branch
5 times, most recently
from
478b1be
to
6bb8f9c
Compare
nilmerg
requested changes
Sep 13, 2023
yhabteab
force-pushed
the
retryable-conn
branch
from
6bb8f9c
to
05ceaaa
Compare
|
Since reporting has already an implementation for it and x509's daemon pings its own database the same as Icinga DB Web does in it's SNI hook with v1.1, we're postponing this to a later release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new connection class that's used to retry some specific temporary database errors before giving up and crashing. The number of retries is set to
1by default, but can be overridden when initiating the connection instance. There is also no time elapsing between the retries.resolves #75