Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type in JWE_EC.dec_setup #159

Open
vernans opened this issue May 2, 2024 · 1 comment · May be fixed by #170
Open

Wrong type in JWE_EC.dec_setup #159

vernans opened this issue May 2, 2024 · 1 comment · May be fixed by #170
Assignees

Comments

@vernans
Copy link

vernans commented May 2, 2024

Hello cryptojwt team,
Thanks for your work, it usually works like a charm.
I found an issue in cryptojwt.jwe.jwe_ec.JWE_EC.dec_setup.

apu and apv are assigned "" when they are declared. When there is no other value in the header for them subsequently ecdh_derive_key crashes because it's trying to concatenate these strings with bytes. I guess they should be assigned a b"".

As I know your time also doesn't grow on trees let me know if I can help you with providing a PR for that.

@jschlyter
Copy link
Contributor

Please create a PR and I'll process it swiftly.

@jschlyter jschlyter self-assigned this May 2, 2024
vernans added a commit to vernans/JWTConnect-Python-CryptoJWT that referenced this issue Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants