Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signed AuthnRequest from entity not in metadata flagged as IncorrectlySigned #256

Open
rhoerbe opened this issue Jul 12, 2019 · 1 comment

Comments

@rhoerbe
Copy link
Contributor

rhoerbe commented Jul 12, 2019

misleading exception if condition mentioned in title occurs

Code Version

4.4.0

Expected Behavior

exception should name the correct cause

Possible Solution

(1) rename exception to "unkown Entity or invalid request signature", or (better)
(2) validate entityid against metadata before validating signature

Steps to Reproduce

  • remove the message obfuscation with rerasing exceptions as SATOSAUnknownError in base.run()
  • issue request from unregistered entity
@peppelinux
Copy link
Member

Also related to
#227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants