Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satosa-saml-metadata script could be more flexible wrt output file names #423

Open
dnmvisser opened this issue Nov 11, 2022 · 1 comment

Comments

@dnmvisser
Copy link
Contributor

Currently the satosa-saml-metadata script creates a metadata file called backend.xml, or, when creating split metadata files, filenames that include an index number:

output.append((create_signed_entity_descriptor(ed, secc, valid), "{}_{}.xml".format(module_name, i)))

So, when one starts to use --split-backend (or --split-frontend), this will cause a change in the generated filenames, which can be problematic as other system might rely on them (aggregator tools etc).

The script could have some options to influence the output file names. Some ideas:

  • An option to override the name of the first file
  • Include the name of the backend/frontend in the file name
@c00kiemon5ter
Copy link
Member

I am planning to do a rewrite but it is not very high on my list.
The idea is to switch to poetry, use typer, rework the plugin loader and routing and then simplify how the options are set and add options to specify output names/patterns/strategies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants