Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal's providing_args removal in 4.0 #315

Closed
g-as opened this issue Oct 27, 2021 · 7 comments · Fixed by #317
Closed

Signal's providing_args removal in 4.0 #315

g-as opened this issue Oct 27, 2021 · 7 comments · Fixed by #317

Comments

@g-as
Copy link
Contributor

g-as commented Oct 27, 2021

providing_args arg has been deprecated since 3.1.

https://docs.djangoproject.com/en/dev/releases/3.1/#id2

I can draft a PR provided some insights on:

  • how to document the arguments
  • whether to keep the providing_args for when version 2.2 and 3.0 (my suggestion would be no)

Since 4.0 beta 1 is out, should we add it to the test matrix?
@peppelinux
Copy link
Member

@g-as thank you, go ahead!

@peppelinux
Copy link
Member

@g-as have you seen this draft?
#292

consider to work on top of this if possibile, thank you

@g-as
Copy link
Contributor Author

g-as commented Nov 16, 2021

I'll take a look at it tomorrow!

@g-as g-as mentioned this issue Nov 17, 2021
Merged
@daggaz
Copy link
Contributor

daggaz commented Feb 16, 2022

Any chance of a release including this any time soon?

@g-as
Copy link
Contributor Author

g-as commented Feb 16, 2022

1.3.6 was released two weeks ago:
https://github.com/IdentityPython/djangosaml2/releases/tag/v1.3.6
https://pypi.org/project/djangosaml2/

@daggaz
Copy link
Contributor

daggaz commented Feb 16, 2022

Whoops! Was looking for a "version X" commit message, missed it. Sorry!

@g-as
Copy link
Contributor Author

g-as commented Feb 16, 2022

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Django 4.0 compatibility
3 participants
@daggaz @peppelinux @g-as