Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid MDQ response when entityID ends with .xml #193

Open
skoranda opened this issue Feb 26, 2020 · 2 comments
Open

invalid MDQ response when entityID ends with .xml #193

skoranda opened this issue Feb 26, 2020 · 2 comments

Comments

@skoranda
Copy link
Contributor

pyFF does not return SAML metadata when the entityID in the MDQ query ends with '.xml' and the request includes the header

Accept: application/samlmetadata+xml

The draft MDQ spec can be found at

https://github.com/iay/md-query/blob/master/draft-young-md-query-saml.txt

Code Version

Commit 7705880

Expected Behavior

pyFF should return SAML metadata (XML) in response to an MDQ query for entityIDs that end in ".xml" when the request includes the header

Accept: application/samlmetadata+xml

Current Behavior

When the entityID ends in '.xml' no SAML metadata is returned for the entity with that entityID even when the header is

Accept: application/samlmetadata+xml

Steps to Reproduce

Prepare a pyFF that parses the metadata aggregate at

http://mds.swamid.se/md/swamid-2.0.xml

and then try

curl \
-H 'Accept: application/samlmetadata+xml' \
http://localhost/entities/https%3A%2F%2Flogin.idp.eduid.se%2Fidp.xml
skoranda added a commit to skoranda/pyff-for-virtual-idp that referenced this issue Mar 3, 2020
The current pyFF code base cannot return metadata for the eduID IdP when
requested by the Shibboleth IdP. See GitHub issue
IdentityPython/pyFF#193
and related Shibboleth SP issue
https://issues.shibboleth.net/jira/browse/SSPCPP-887
This commit adds a simple local patch to workaround the issue
for now.
@leifj
Copy link
Contributor

leifj commented Mar 16, 2023

I believe this was fixed with the content negotiation policy feature yes?

@skoranda
Copy link
Contributor Author

Sorry, I don't have a pyFF deployment anymore with which I can test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants