Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme forced via chrome://flags makes entire row disappear on hover (black text on black background) should be avoided #178

Open
3ICE opened this issue Sep 6, 2021 · 3 comments
Labels
question Further information is requested rework Refactors, updates to structure, or other large changes

Comments

@3ICE
Copy link

3ICE commented Sep 6, 2021

image
(Stamp levels are invisible for another reason, see #177)

image
(Number Scroller looks bad for a different reason, see #177 )

@adapap
Copy link
Collaborator

adapap commented Sep 10, 2021

Not entirely sure what the expected change is on our end here? I use Chrome in dark mode and I haven't had such issues. Does this issue still occur on refresh, and is there any way to reproduce without changing Chrome's flags by hand?

@adapap adapap added the question Further information is requested label Sep 10, 2021
@3ICE
Copy link
Author

3ICE commented Sep 11, 2021

No this probably only happens if end users force dark mode controls even on non-compatible websites. (#enable-force-dark and #form-controls-dark-mode flags.)

The expectation is that more and more websites will support dark mode UI elements eventually or have their own dark mode switch. A CSS property called prefers-color-scheme is supposed to be implemented by the compatible themes:

@media(prefers-color-scheme:dark)

but I don't see how...

Force Dark Mode for Web Contents
Automatically render all web contents using a dark theme.
+
Web Platform Controls Dark Mode
If enabled, forms controls and scrollbars will be rendered with a dark theme, only on web pages that support dark color schemes, and when the OS is switched to dark theme.

Now this second flag is the one that breaks far more websites.

See also:
mozilla-mobile/firefox-ios#5772

@3ICE
Copy link
Author

3ICE commented Sep 11, 2021

I may have found something! https://idleoncompanion.com/assets/index.b471be5f.css

.q-table tbody tr.selected td:after, body.desktop .q-table>tbody>tr:not(.q-tr--no-hover):hover>td:not(.q-td--no-hover):before {
  content: "";

Seems to be actually blanking the entire row on hover, so our issue is not just an incompatible (black on black) color choice. Not sure how :before replaces content instead of adding to it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested rework Refactors, updates to structure, or other large changes
Projects
None yet
Development

No branches or pull requests

2 participants