Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

Update to Harmony 2.0 #13

Open
Ijwu opened this issue Apr 2, 2020 · 1 comment
Open

Update to Harmony 2.0 #13

Ijwu opened this issue Apr 2, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Ijwu
Copy link
Owner

Ijwu commented Apr 2, 2020

PPML is stuck on Harmony 1.2 for the time being. Harmony 1.2 has been deprecates and 2.0 is the suggested route forward.

There is one main issue with this: Harmony patches for 1.2 are not inherently compatible with 2.0. Meaning this could break compat... again. I'm loathe to commit to doing that so another way will have to be made available.

Options:

  • Ship with Harmony 1.2 for those mods which use it anyway, but port PPML to 2.0.
  • Create a compat layer for 1.2 <-> 2.0.
@Ijwu Ijwu added the enhancement New feature or request label Apr 2, 2020
@Sheep-y
Copy link

Sheep-y commented Apr 11, 2020

I've tried it with modnix, from commit df9a60 to commit 1a03c1, and gave up.

The bridge part is independent from other code so you may take that if you want to give it a try. Code: Compat layer (first attempt), coexistance patch (second attempt).

My conclusion is that both Harmony cannot co-exist in same AppDomain, and obviously Harmony won't work if it is loaded into a separate domain. If I am to try again I'd properly clone Harmony 2.0 and mix in my bridge code.

Good luck. If you can solve the problem, you will be the hero for many modders.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants