Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Web App #32

Open
stevenkbennett opened this issue Jul 2, 2022 · 3 comments
Open

Adding Web App #32

stevenkbennett opened this issue Jul 2, 2022 · 3 comments

Comments

@stevenkbennett
Copy link

Thanks for the great work on the template!

I have made a web app for my work: https://github.com/stevenkbennett/SupraShare_SA_Model, and am at the stage where I have pushed the Docker image to the GitHub repository. I'm a little confused as to what the next steps I should take are.
I know that I need to update the docker-compose.yml file with the details of the web app. Should I submit a PR to SupraShare repository on the Imperial repository with the updated docker-compose?
My understanding is the web server is set to check this file periodically for changes. Are the Caddyfile, app-list.yaml, and index.html files on the web server? If so, is this something the user should update or the maintainer of webserver? Thanks!

@dandavies99
Copy link
Contributor

Glad you've found the template useful! Would you be able to add @AdrianDAlessandro and me to the SupraShare_SA_Model so we can take a look?

If you've created the Docker image as you describe, this is indeed as far as you can get without access to the remote server. The files, including docker-compose.yml have to be updated manually there. I'll contact you separately to show you how to do this.

@stevenkbennett
Copy link
Author

Yes, I particularly like the CI integration - makes updating the Docker image very easy! As the image is hosted on GitHub, I assume the file size is limited?

I've added you both as collaborators in the repository.

@dandavies99
Copy link
Contributor

Good question re size limits. The pricing structure seems complicated but the limits look quite generous. I doubt we'd run into problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants