Remove .vscode/settings.json

[cc-a]

Removes vscode settings file and adds to .gitignore.

Having the settings commited requires developers to have a dirty worktree in order to customise project specific settings.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (235f980) to head (96e7210).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           43        43           
=========================================
  Hits            43        43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dalonsoa]

In general, the point of having this committed is for the developers contributing to a specific project to have the same settings to improve consistency and NOT customise them at workspace level. If they want customisation, they can do so at User level, right?

[cc-a]

Consistency is enforced via CI. I'd argue the developer should be free to have whatever development experience they want in their editor without being forced to configure things at the user level which doesn't have project isolation.

[dalonsoa]

OK, then.

[jamesturner246]

No strong opinion here 👍

[alexdewar]

I'm not convinced. I get that it's a bit weird, but it's pretty common practice to commit the settings.json file to git (e.g. here's the one in VS Code's own repo). It's handy to be able to set the default formatter for Python files etc. Yes, we enforce it properly with pre-commit/CI, but this is really just for convenience.

That said, there are clearly other people out there who want to be able to override the workspace settings.json without having a dirty git tree, which seems a sensible proposal: microsoft/vscode#40233

There aren't that many settings in the file, so I don't think it matters too much if we drop it (but I will continue to commit settings.json for my own projects 😉). Up to you!