Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make object ownership compulsory #221

Closed
tsmbland opened this issue Mar 13, 2024 · 3 comments · Fixed by #387
Closed

Make object ownership compulsory #221

tsmbland opened this issue Mar 13, 2024 · 3 comments · Fixed by #387
Assignees
Labels
bug Something isn't working core functionality Improvement to bring functionality to standard of the iMHEA system

Comments

@tsmbland
Copy link
Member

Currently owner is an optional field for the models. This was required to get it to work with the initial data, however we need to make ownership compulsory so we'll have to make some changes here

@tsmbland
Copy link
Member Author

Technically owner is still an optional field in the sense that null=True and blank=True. That said, for all intents and purposes, ownership is mandatory as any new objects created through the admin will be owned by whoever created them, and this cannot be changed.

The only reason I haven't changed the null/blank options in the model is that this wouldn't work with the initial data, which doesn't have an owner specified.

@dalonsoa Is there anything I need to do for this, or is it ok to close the issue?

@dalonsoa
Copy link
Collaborator

Let's leave it as it is, for now. It will need to be tackled when - in the future, someone - porting the existing production system to Paricia.

@tsmbland tsmbland removed their assignment Apr 10, 2024
@dalonsoa dalonsoa added the bug Something isn't working label Jun 13, 2024
@dalonsoa dalonsoa added the core functionality Improvement to bring functionality to standard of the iMHEA system label Oct 7, 2024
@dalonsoa dalonsoa self-assigned this Oct 7, 2024
@dalonsoa
Copy link
Collaborator

dalonsoa commented Oct 8, 2024

A solution for this could be to add a "default admin" user that gets assigned anything imported to the DB "manually", i.e. not using the forms. Something to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core functionality Improvement to bring functionality to standard of the iMHEA system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants