Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row selection not matching activation status #250

Closed
tsmbland opened this issue Apr 4, 2024 · 3 comments
Closed

Row selection not matching activation status #250

tsmbland opened this issue Apr 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working frontend
Milestone

Comments

@tsmbland
Copy link
Member

tsmbland commented Apr 4, 2024

The main callback in the validation app is designed to automatically select entries for which is_active is True, whenever data is loaded. However this doesn't seem to be working properly. I'm not sure what's going wrong.

@dalonsoa dalonsoa added the bug Something isn't working label Jun 13, 2024
@dalonsoa dalonsoa added this to the Version 1.0.1 milestone Sep 19, 2024
@dalonsoa dalonsoa self-assigned this Oct 7, 2024
@dalonsoa dalonsoa modified the milestones: Version 1.0.1, Version 1.1.0 Oct 7, 2024
@dalonsoa
Copy link
Collaborator

dalonsoa commented Oct 8, 2024

@tsmbland , I cannot reproduce the error. If I manually validate a couple of entries in the Admin, marking one as active and the other one as inactive:

Image

the checkbox appears correct checked/unchecked based on that activation status when going to the validation screen:

Image

Maybe it was fixed automatically in the meantime?

@dalonsoa
Copy link
Collaborator

dalonsoa commented Oct 8, 2024

Obviously, they only appear when requesting validated data. When requesting not validated data, only active entries appear since they can only be set as not active if they are also validated. See

if not self.is_validated and not self.is_active:

@dalonsoa
Copy link
Collaborator

Closing, for now as it does not seem to be an issue anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

2 participants