Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-definable Delta T can be removed #329

Closed
ICHydro opened this issue Sep 19, 2024 · 2 comments · Fixed by #352
Closed

User-definable Delta T can be removed #329

ICHydro opened this issue Sep 19, 2024 · 2 comments · Fixed by #352
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ICHydro
Copy link
Collaborator

ICHydro commented Sep 19, 2024

Is your feature request related to a problem or limitation? Please describe.

We should not need the user to create an object "Delta T". This is the time interval of the time series of a station, and can be calculated from the data. Also, the time interval is not necessarily constant for a (raw) time series, for example data may be available every 5 minutes for some part of the time series and 10 minutes for another part.

Describe the solution you'd like
The system should be able to calculate Delta T from the time series, and ideally be able to deal with irregular time series (which have a varying delta T).

@ICHydro ICHydro added the enhancement New feature or request label Sep 19, 2024
@dalonsoa
Copy link
Collaborator

dalonsoa commented Sep 20, 2024

In principle, this is done like this by design. The user inputs an expected Delta T and checks the data against that Delta T during the validation, flagging entries that do not follow that separation as suspicious. See the checks done in the validation. This was implemented by Pablo and, I presume, it was one of the checks done directly in SQL code.

Delta T is not needed for anything else, so if it is not input by the user, I don't think there's any need to calculate it out of the data and can be removed altogether. It always looked to me as a fragile setting, anyway. What do you think, @ICHydro ?

@dalonsoa dalonsoa added this to the Version 1.1.0 milestone Sep 20, 2024
@ICHydro
Copy link
Collaborator Author

ICHydro commented Sep 22, 2024

Let's remove this for now. I agree that it looks fragile, and in principle, the system should be able to deal with irregular time series. If there is a need to do a sanity check on time intervals then there are more sophisticated ways to deal with this. Also, if we want to store a delta T value then it may be easier to store this directly as a float in the sensor table.

@Sahil590 Sahil590 linked a pull request Sep 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants