Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not clear if/when data statistics such as minimum and maximum are calculated #342

Open
ICHydro opened this issue Sep 20, 2024 · 3 comments

Comments

@ICHydro
Copy link
Collaborator

ICHydro commented Sep 20, 2024

Describe the bug
it is not clear if or when statistics such as daily minimum and maximum are calculated. After importing new data, these statistics show up as zero in the "validation" page (see screenshot).

Expected behavior
Either they should be calculated automatically during an import, or there should be a way for the user to request their calculation manually (perhaps together with the calculation of daily and monthly aggregates - see also issue 339)

Screenshots
Screenshot 2024-09-20 170341

@ICHydro ICHydro added the bug Something isn't working label Sep 20, 2024
@dalonsoa
Copy link
Collaborator

These are not statistics, but input data that is pulled from the input file, if available. If there's no columns for the maximum and minimum, then this data is set as zero.

@dalonsoa dalonsoa removed the bug Something isn't working label Sep 20, 2024
@ICHydro
Copy link
Collaborator Author

ICHydro commented Sep 22, 2024

OK, thanks. I can't see a reason why one would want to import minima and maxima of individual data points. Most data points are a single observation anyway, and therefore do not have a min and a max. Some sensors may provide a minimum or maximum over a time interval (e.g, minimum temperature) but this can be treated as a separate time series. I will check with FONAG why this functionality is present in their system.

@dalonsoa
Copy link
Collaborator

dalonsoa commented Oct 4, 2024

@ICHydro , is there any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants