Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Association back and use it in new Add and Edit data import forms to limit format choices #90

Closed
dandavies99 opened this issue Jul 26, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@dandavies99
Copy link
Contributor

If the wrong format is chosen for a raw data file, it's possible that everything appears to work but no actual measurement data is added.

  1. At the frontend, we should make sure that we use the Association to limit Format choices that are relevant to the station that has been selected.
  2. At the backend, we should raise a warning (maybe it's some property of DataImportFull that can be made obvious to the user) if no data is imported. Perhaps this should be if the number of columns imported doesn't match the number of columns in the file.
@dalonsoa dalonsoa added the enhancement New feature or request label Sep 16, 2024
@dalonsoa dalonsoa added this to the Version 1.1.0 milestone Sep 16, 2024
@dalonsoa
Copy link
Collaborator

We need to bring Association back into the mix, removed in d5ead03

@dalonsoa dalonsoa changed the title Behaviour when "wrong" format chosen Bring Association back and use it in new Add and Edit data import forms to limit format choices Sep 23, 2024
@dalonsoa
Copy link
Collaborator

dalonsoa commented Oct 4, 2024

Ditch in favour of a M2M relationship, better error handling and documentation. See #373 and #333 .

@dalonsoa dalonsoa closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants