Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the attributes of the PModel and SubdailyPModel implementations #386

Open
Tracked by #383
davidorme opened this issue Jan 13, 2025 · 0 comments
Open
Tracked by #383

Comments

@davidorme
Copy link
Collaborator

davidorme commented Jan 13, 2025

We currently have completely inconsistent naming for the attributes of the PModel and SubdailyPModel. The table below isn't yet complete - I think the thing to do is probably make the __init__ methods logic free and have a complete listing of attributes and docstrings there, that then calls a private _fit_model method to isolate the logic.

See also #385 and #384 which overlap considerably. Probably close those two first - a bit around the houses but reducing the number of things being changed in one PR. This one is a big one.

Use Current PModel Current SubdailyPModel
lue lue ???
iwue iwue ???
vcmax vcmax subdaily_vcmax
vcmax25 vcmax25 subdaily_vcmax25
vcmax25_daily_optimal NA vcmax25_opt
vcmax25_daily_realised NA vcmax25_real
jmax jmax subdaily_jmax
jmax25 Not currently exposed subdaily_jmax25
jmax25_daily_optimal NA jmax25_opt
jmax25_daily_realised NA jmax25_real
xi self.pmodel_acclim.optchi.xi - add a getter? subdaily_xi
xi_daily_optimal NA self.pmodel_acclim.optchi.xi Maybe add a getter?
xi_daily_realised NA xi_real
gpp gpp gpp
gs gs ???
ppfd ppfd ???
fapar fapar ???
rd rd ???
Ac Not currently exposed subdaily_Ac
Ac Not currently exposed subdaily_Aj
J Not currently exposed `Not currently exposed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant