-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination to secrets dashboard to reduce lag #2224
Comments
I will work on it! Please assign it to me. |
Is this feature approved? If yes, I can get started |
hey @Vishvsalvi are you still working on this? |
Yes I'm working on this one |
hey @Vishvsalvi, are you working on this still ? |
Yes, I'm figuring few things out if I don't make a PR by 18th I'll unassign it by myself. |
@maidul98 does this look good? |
Hey @maidul98, I've raised a PR. I would like to have a code review if anything is wrong. |
I would like to work on this issue can i? |
This feature has been released and now available. |
Feature description
Right now, all secrets are fetched in at a given secret path. However, when the number of secrets goes past 500, the UI will start o lag. In order to resolve this, we need to introduce pagination so that each page is limited to the number of secrets it can show. All search and download functions must work as expected as apart of this change.
The text was updated successfully, but these errors were encountered: