Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to secrets dashboard to reduce lag #2224

Closed
maidul98 opened this issue Aug 2, 2024 · 10 comments · May be fixed by #2302
Closed

Add pagination to secrets dashboard to reduce lag #2224

maidul98 opened this issue Aug 2, 2024 · 10 comments · May be fixed by #2302
Labels
good first issue Good for newcomers linear This tag is used to sync issues with Infisical's internal project management system.

Comments

@maidul98
Copy link
Collaborator

maidul98 commented Aug 2, 2024

Feature description

Right now, all secrets are fetched in at a given secret path. However, when the number of secrets goes past 500, the UI will start o lag. In order to resolve this, we need to introduce pagination so that each page is limited to the number of secrets it can show. All search and download functions must work as expected as apart of this change.

@maidul98 maidul98 added good first issue Good for newcomers linear This tag is used to sync issues with Infisical's internal project management system. labels Aug 2, 2024
@Vishvsalvi
Copy link
Contributor

Vishvsalvi commented Aug 2, 2024

I will work on it! Please assign it to me.

@Vishvsalvi
Copy link
Contributor

Is this feature approved? If yes, I can get started

@sambhav2612
Copy link

hey @Vishvsalvi are you still working on this?

@Vishvsalvi
Copy link
Contributor

Yes I'm working on this one

@MuhmdAjeer
Copy link

hey @Vishvsalvi, are you working on this still ?

@Vishvsalvi
Copy link
Contributor

Yes, I'm figuring few things out if I don't make a PR by 18th I'll unassign it by myself.

@Anonymous961
Copy link

@maidul98 does this look good?
image
image
can I make a PR?

@Anonymous961
Copy link

Hey @maidul98, I've raised a PR. I would like to have a code review if anything is wrong.

@VenkateshSircilla123
Copy link

I would like to work on this issue can i?

@akhilmhdh
Copy link
Member

This feature has been released and now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers linear This tag is used to sync issues with Infisical's internal project management system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants