Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags should be an array #396

Open
jon4hz opened this issue Mar 1, 2023 · 1 comment · May be fixed by #2465
Open

Tags should be an array #396

jon4hz opened this issue Mar 1, 2023 · 1 comment · May be fixed by #2465
Labels
💻 code improvements

Comments

@jon4hz
Copy link
Contributor

jon4hz commented Mar 1, 2023

Feature description

Hi, I didn't dig to deep into the api yet but from what I see, the tags are currently treated as a single string.

infisical/cli/packages/api/model.go

Line 200 in 9914414

TagSlugs string `json:"tagSlugs"`

Shouldn't that field be a string array?

Why would it be useful?

Makes the API a bit cleaner.
@maidul98
Copy link
Collaborator

maidul98 commented Mar 1, 2023

It's a list of strings separated by commas such as tags1,tags2,tags3. I agree making it a list and then converting the list to a comma separated list may be more initiative

@AayushSaini101 AayushSaini101 linked a pull request Sep 22, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Change the datatype of String to array string AayushSaini101/infisical
2 participants
@maidul98 @jon4hz