Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers #2503

Open
jsoref opened this issue Sep 27, 2024 · 0 comments

Comments

@jsoref
Copy link

jsoref commented Sep 27, 2024

This message comes from kubernetes, a user encountered it:

https://questions.infisical.com/2J3ea21

2024-08-27T01:25:28Z INFO KubeAPIWarningLogger metadata.finalizers: "http://secrets.finalizers.infisical.com|secrets.finalizers.infisical.com": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers

The code in Infisical is:

const FINALIZER_NAME = "secrets.finalizers.infisical.com"

In theory the fix is something like this:

- const FINALIZER_NAME = "secrets.finalizers.infisical.com" 
+ const FINALIZER_NAME = "secrets.infisical.com/finalizer"

In practice, you may need to include some migration support, here's how I did it for cert-manager: cert-manager/cert-manager@bbb21d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant