Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yaml to support .env for easy setting alternatives #16

Open
mpo-vliz opened this issue Dec 10, 2024 · 2 comments · May be fixed by #17
Open

docker-compose.yaml to support .env for easy setting alternatives #16

mpo-vliz opened this issue Dec 10, 2024 · 2 comments · May be fixed by #17

Comments

@mpo-vliz
Copy link

Testing this we see a conflict on port 8080. (It is already in use on our platform)

Need to investigate the docker-compose to change.
What is confusing concerning the usage of the 8080 external port is

As a suggestion -- it would be great if this project thinks upfront about sensible things that are likely to change and organize them through injected environment variables (through .env)

  • then provide some dotenv-example file inside the project, this serves as a more clear sort of documentation on things to share + provides a known and organized way to actually tune them.

Will provide a PR giving some suggestion in that direction

mpo-vliz pushed a commit to vliz-be-opsci/VSDS-TestBed-Shacl-Validator that referenced this issue Dec 10, 2024
@mpo-vliz
Copy link
Author

PR provided in #17

@jobulcke
Copy link
Collaborator

Thanks for creating this issue and the PR, I approved both PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants