Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading model weights more efficiently #119

Open
3 tasks
kerthcet opened this issue Sep 2, 2024 · 7 comments
Open
3 tasks

Loading model weights more efficiently #119

kerthcet opened this issue Sep 2, 2024 · 7 comments
Assignees
@kerthcet
Labels
feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Milestone
v0.2.0

Comments

@kerthcet
Copy link
Member

kerthcet commented Sep 2, 2024

What would you like to be added:

Right now we can download model weights from model hub directly, but each time we start/restart a pod, it will downloading the model weights again. Without the loading accelerators like fluid or dragonfly, we should think of a way to tackle this more efficiently, let's focus on three things:

  • download the models the first time should be as quick as possible
  • don't need to download the model weights again when pod restarted
  • handle the model cache efficiently

Why is this needed:

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.
@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-kind Indicates a PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. labels Sep 2, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Sep 2, 2024

/milestone v0.1.0

@InftyAI-Agent InftyAI-Agent added this to the v0.1.0 milestone Sep 2, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Sep 2, 2024

/kind feature

@InftyAI-Agent InftyAI-Agent added feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a label and requires one. labels Sep 2, 2024
@kerthcet
Copy link
Member Author

/assign

@InftyAI InftyAI deleted a comment from InftyAI-Agent Sep 14, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Sep 18, 2024 •
edited
Loading

We may implement a simplified p2p network for efficient model distributing. See https://github.com/InftyAI/Manta

@kerthcet
Copy link
Member Author

How transformer handles large models: https://huggingface.co/docs/transformers/big_models

@kerthcet kerthcet removed their assignment Oct 8, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Oct 8, 2024

/assign

@kerthcet kerthcet mentioned this issue Oct 8, 2024
Open
@kerthcet kerthcet mentioned this issue Nov 14, 2024
Closed
3 tasks
@kerthcet
Copy link
Member Author

/milestone v0.2.0
as Manta needs more developing time.

@InftyAI-Agent InftyAI-Agent modified the milestones: v0.1.0, v0.2.0 Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerthcet kerthcet

Labels
feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@kerthcet @InftyAI-Agent