You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dtk-tools used to do this, and is critical for all calibration analyzers, otherwise their sample index values are string-sorted (0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9) instead of int sorted (0, 1, 2, 3, 4, 5, ...). For calibration, this could lead to inappropriate matching between analyzer scores and the parameter sample it is supposed to be linked to.
I have diagnosed this as a non-feature parity issue between idmtools <-> dtk-tools that does not depend on pyComps or pandas.
We will need to decide if numerical conversion of tag values is up to the user (in analyzers, etc) or is reliably done by idmtools, or have calibra convert just-this-tag, as every ported dtk-tools -> idmtools calibration analyzer will be exposed to this error.
Discussion and details from teams:
The text was updated successfully, but these errors were encountered:
To give the more history context, we used to fix Prashanth and Jillian's calibration with 2 lines of code at right before return result in analyzer's reduce function to first convert result index(which is sample_index tag) to int then sort by index. But this solution basically needs each user to remember this 2 lines of code. other wise, calibration result will be screwed up.
If we can change in idmtools or some where not ask user to do it, it would be idea solution.
I think maybe we could add a function the the IEntity(has the tags object on it) to make it easier for users to easily convert the columns in tags to specific datatypes. My first instinct is to imitate libraries that users are familiar with, so looking at Dataframe constructor as inspiration(see https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.html), we could add something like
dtk-tools used to do this, and is critical for all calibration analyzers, otherwise their sample index values are string-sorted (0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9) instead of int sorted (0, 1, 2, 3, 4, 5, ...). For calibration, this could lead to inappropriate matching between analyzer scores and the parameter sample it is supposed to be linked to.
I have diagnosed this as a non-feature parity issue between idmtools <-> dtk-tools that does not depend on pyComps or pandas.
We will need to decide if numerical conversion of tag values is up to the user (in analyzers, etc) or is reliably done by idmtools, or have calibra convert just-this-tag, as every ported dtk-tools -> idmtools calibration analyzer will be exposed to this error.
Discussion and details from teams:
The text was updated successfully, but these errors were encountered: