From 92f16a1fceed797ebba6708194a45daaaf2a477e Mon Sep 17 00:00:00 2001 From: Hema Date: Wed, 2 Jul 2014 17:09:59 +0200 Subject: [PATCH] Fixed setting front camera parameters on all devices --- .../src/com/integreight/onesheeld/Log.java | 2 +- .../controller/utils/CameraHeadService.java | 19 ++++++++++--------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/OneSheeld/src/com/integreight/onesheeld/Log.java b/OneSheeld/src/com/integreight/onesheeld/Log.java index 159c65135..614ecd6cf 100644 --- a/OneSheeld/src/com/integreight/onesheeld/Log.java +++ b/OneSheeld/src/com/integreight/onesheeld/Log.java @@ -2,7 +2,7 @@ public class Log { public static void d(String tag, String msg) { -// android.util.Log.d(tag, msg); + android.util.Log.d(tag, msg); } public static void i(String tag, String msg) { diff --git a/OneSheeld/src/com/integreight/onesheeld/shields/controller/utils/CameraHeadService.java b/OneSheeld/src/com/integreight/onesheeld/shields/controller/utils/CameraHeadService.java index f2423b88e..c3e4c68b6 100644 --- a/OneSheeld/src/com/integreight/onesheeld/shields/controller/utils/CameraHeadService.java +++ b/OneSheeld/src/com/integreight/onesheeld/shields/controller/utils/CameraHeadService.java @@ -213,10 +213,11 @@ public void run() { stopSelf(); } - parameters = mCamera.getParameters(); - parameters.setFlashMode(FLASH_MODE); - // set biggest picture - setBesttPictureResolution(); + Camera.Parameters parameters = mCamera.getParameters(); + pictureSize = getBiggesttPictureSize(parameters); + if (pictureSize != null) + parameters + .setPictureSize(pictureSize.width, pictureSize.height); // set camera parameters mCamera.setParameters(parameters); @@ -269,11 +270,11 @@ public void run() { stopSelf(); } - parameters = mCamera.getParameters(); - parameters.setFlashMode(FLASH_MODE); - - // set biggest picture - setBesttPictureResolution(); + Camera.Parameters parameters = mCamera.getParameters(); + pictureSize = getBiggesttPictureSize(parameters); + if (pictureSize != null) + parameters + .setPictureSize(pictureSize.width, pictureSize.height); // set camera parameters mCamera.setParameters(parameters);