Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: velocity estimation in joint_states for xs_sdk_sim #55

Open
cmower opened this issue Sep 19, 2024 · 1 comment
Open

[Enhancement]: velocity estimation in joint_states for xs_sdk_sim #55

cmower opened this issue Sep 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@cmower
Copy link

cmower commented Sep 19, 2024

Describe the solution you'd like

In xs_sdk_sim, only the joint_states.position values are included - this is inconsistent with the real robot interface in xs_sdk_obj.cpp.

Platform

x-series arms

Is your feature request related to a problem? Please describe.

In some of my use-cases, I use the velocity from the real robot - I need to add hacks to my code in order to handle the simulation vs real cases.

Suggested code

I forked the repo, implemented backward differencing to estimate the velocity, and setup a PR #56

Additional Info

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants
@cmower and others