Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optparse-applicative-fork dependency, and functions depending on it #635

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Sep 12, 2024

Changelog

- description: |
    Removes the dependency to `optparse-applicative-fork`, as it is unused internally and not useful for users.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

API depends on optparse-applicative-fork here. This dependency is not really useful and in addition it's a fork we depend on, not on the main version.

How to trust this PR

  1. Code compiles.
  2. CLI PR adapting to this change exists: Move parsing helpers from API cardano-cli#894

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Can you mark this PR as breaking as well? We're changing the exposed API.

@smelc smelc added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit eb2108c Sep 12, 2024
27 of 28 checks passed
@smelc smelc deleted the smelc/remove-opt-parse-dependency branch September 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants