Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Update cardano-cli conway query spo-stake-distribution #911

Open
2 of 17 tasks
CarlosLopezDeLara opened this issue Sep 24, 2024 · 2 comments
Open
2 of 17 tasks
Assignees
Labels
conway-feature intra-era-hardfork feature to be added for protocol version 10

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Sep 24, 2024

What

We need to update the output of cardano-cli conway query spo-stake-distribution to include the DREP delegation choices of the Pool's rewards accounts. This, once IntersectMBO/cardano-ledger#4645 is implemented, in particular:

To be more specific the solution to this problem is:

1.  To change the default vote for SPOs to `No` from `Abstain` for all of the three proposals in question
2. Check whether SPO's reward address is delegated to the predefined `AlwaysNoConfidence` DRep and count default vote as `Yes` only on `NoConfidence` proposals for that SPO.
3. Check whether SPO's reward address is delegated to predefined `AlwaysAbstain` DRep and count default vote as `Abstain` for that SPO on all three: `NoConfidence`, `UpdateCommitee` and `ParameterUpdate` proposals.

For example:

    [
        "dec39dd553180bf78b206258aba3861537b185580086ca3f62716f8d",
        10868846712397,
        "drep-alwaysAbstain"
    ],
    [
        "e2fd1cd89bba55dc457574adf420240c28a2bfdb3d460279e453c57a",
        10671709098807,
        "drep-keyHash-ffc25bcec3379aea4e32f353b4048fc7ab9fc1124c01738546e2f7bb"
    ],
    [
        "eec73ca2652e1ae92852195ff3289dd991a83dbe5f989f06e1c96b64",
        10703582488560,
        "drep-alwaysNoConfidence"
    ],
    [
        "f386ee192cf53c26da7457b7d8992ae0e52a05fc1c88c5d653a90021",
        10466189795103,
        "drep-scriptHash-186e32faa80a26810392fda6d559c7ed4721a65ce1c9d4ef3e1c87b4"
    ]

(Thank you @gitmachtl)

Why

IntersectMBO/cardano-ledger#4645 changes the way SPO votes are counted. The SPO reward account delegation choice will impact how the pool's stake counts for voting. It is important to show this information so that downstream tools can recreate the vote count.

Personas

  • SPOs
  • dApp Devs
  • Exchanges
  • Wallets
  • 3rd party tools
  • ADA holders

Definition of Done (DoD)

  • Acceptance Criteria + User Stories & DoD created and singed-off (by PO, dev & test owners)
  • Builds successfully on CI
  • Code & Test review (as per Acceptance Criteria)
  • There is documentation and/or examples for the new functionality (usage/response)
  • Log/record changes on Vnext (or similar depending on what we adopt)
  • Ticket number(s) included in PR description
  • All Acceptance Criteria met and covered by dev/unit/property/integration tests
  • System/E2E automated tests + System Test Engineer Owner Sign-off

NOTE: Ideally, we should merge only fully implemented and tested features into the master branch.
So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged
after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off
was not provided (last step in the DoD).

IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.

Sign-off

  • Product Owner
  • Dev Owner
  • System Test Engineer Owner

Related PRs

Acceptance Criteria

The output must show the SPO rewards account delegation choice: "registered DRep", "Always abstain" or "Always no confidence"

@CarlosLopezDeLara CarlosLopezDeLara added conway-feature intra-era-hardfork feature to be added for protocol version 10 labels Sep 24, 2024
@gitmachtl
Copy link
Contributor

here is the cross reference to the ledger part
IntersectMBO/cardano-ledger#4663

@smelc smelc self-assigned this Oct 30, 2024
@gitmachtl
Copy link
Contributor

i will extended this FR to also change the spo-stake-distribution name into spo-power-distribution or spo-votepower-distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conway-feature intra-era-hardfork feature to be added for protocol version 10
Projects
None yet
Development

No branches or pull requests

3 participants