Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance metadata is not validated #906

Open
saratomaz opened this issue Sep 20, 2024 · 3 comments · May be fixed by IntersectMBO/cardano-api#713 or #995
Open

Governance metadata is not validated #906

saratomaz opened this issue Sep 20, 2024 · 3 comments · May be fixed by IntersectMBO/cardano-api#713 or #995
Assignees
@palas
Labels
conway-feature intra-era-hardfork feature to be added for protocol version 10
Milestone
SanchoNet Phase 7...

Comments

@saratomaz
Copy link

Description

There is no metadata validation for the governance metadata. Right now is possible to submit a governance action with wrong metadata/missing required fields and the only time we can see an error is when dbsync try to catch the data.

Steps to Reproduce

e.g.

  1. run cardano-cli conway governance drep metadata-hash --drep-metadata-file drep_metadata.json
    drep_metadata.json -> missing givenName that is marked as Compulsory in cip-0119
  2. No error is returned

Additional Context

CIPs related to governance metadata:
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0100
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0108
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0119
@kderme
Copy link
Contributor

kderme commented Sep 20, 2024

In case cli plans to support this, we have implemented metadata parsers following the above cips https://github.com/IntersectMBO/cardano-db-sync/blob/master/cardano-db-sync/src/Cardano/DbSync/OffChain/Vote/Types.hs

@palas palas self-assigned this Sep 23, 2024
@CarlosLopezDeLara CarlosLopezDeLara added conway-feature intra-era-hardfork feature to be added for protocol version 10 and removed conway-era-integration-bug labels Sep 24, 2024
@gitmachtl
Copy link
Contributor

cardano-signer is doing checks if a metadata file is valid, also checks about the signatures.

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Nov 20, 2024
@smelc smelc removed the Stale label Dec 3, 2024
@palas palas mentioned this issue Dec 5, 2024
Open
@palas palas mentioned this issue Dec 16, 2024
Open
@palas palas linked a pull request Dec 20, 2024 that will close this issue
Add JSON schema checking functionality for DRep and Gov action metadata IntersectMBO/cardano-api#713
Open
3 tasks
This was referenced Dec 20, 2024
Open
Open
@palas palas linked a pull request Dec 20, 2024 that will close this issue
Add JSON schema checking functionality for DRep and Gov action metadata #995
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palas palas

Labels
conway-feature intra-era-hardfork feature to be added for protocol version 10
Projects
None yet
Milestone
SanchoNet Phase 7 (Queries and extras)
6 participants
@smelc @palas @kderme @gitmachtl @CarlosLopezDeLara @saratomaz