Add a test of create-cardano

[smelc]

Changelog

- description: |
    Add a test of create-cardano
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Since I'm going to share some code between create-cardano and create-testnet-data (for #765), I thought this was a good occasion to at least call create-cardano once in our tests. It's bad to provide a command and not test it at all.

How to trust this PR

The new test passes

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[carbolymer]

there's already genesis in cardano-cli/test/cardano-cli-test/files/input/alonzo/genesis.alonzo.spec.json - why not reuse it?

[smelc]

@carbolymer> are you sure you don't have an untracked file lying around? I don't see it:

→ git ls-files | grep ^cardano-cli | grep genesis | grep json
cardano-cli/test/cardano-cli-golden/files/golden/conway/custom-lovelace-supply-shelley-genesis.json
cardano-cli/test/cardano-cli-golden/files/input/alonzo/genesis.alonzo.spec.json
cardano-cli/test/cardano-cli-golden/files/input/conway/genesis.conway.spec.json
cardano-cli/test/cardano-cli-golden/files/input/shelley/genesis/genesis.spec.json
cardano-cli/test/cardano-cli-golden/files/input/shelley/genesis/relays.json
cardano-cli/test/cardano-cli-test/files/input/conway/create-cardano/genesis.alonzo.spec.json
cardano-cli/test/cardano-cli-test/files/input/conway/create-cardano/genesis.byron.spec.json
cardano-cli/test/cardano-cli-test/files/input/conway/create-cardano/genesis.conway.spec.json
cardano-cli/test/cardano-cli-test/files/input/conway/create-cardano/genesis.shelley.spec.json

The last 4 files are the ones added by this PR.

[smelc]

@carbolymer> Note that I didn't reuse files in cardano-cli/test/cardano-cli-golden/files/input/, because my test is not a golden test, so my inputs files need to be in cardano-cli/test/cardano-cli-test/files/input/.

[carbolymer]

Ah right, I've confused paths. The files I mentioned (in my other comments too) are in cardano-cli-golden.

My main concern here is having two checked-in files representing the same thing. Their values (protocol params, cost models etc.) rely on some hidden assumptions and simplifications, so it may be harder to figure out the correct genesis for a new test you'd be potentially writing in the future if you have multiple choices available.

The other thing is updating them. In case of conway, the values were changing from time to time, so it was annoying to update manually input files.

I guess maybe we should make a test checking if they're up to date with mainnet ones? 🤔 I guess it does not matter at this very moment much - conway genesis won't change much.

[carbolymer]

I think it would be better to put it in cardano-cli/test/cardano-cli-test/files/input/byron/genesis.byron.spec.json

[carbolymer]

Same we already have conway genesis in repo

[carbolymer]

Same, we already have shelley genesis in cardano-cli/test/cardano-cli-test/files/input/shelley/genesis/genesis.spec.json

[smelc]

Same as above, I don't find it 🙁