Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new predicate failure for non-matching withdrawals #4640

Open
lehins opened this issue Sep 20, 2024 · 0 comments
Open

Add a new predicate failure for non-matching withdrawals #4640

lehins opened this issue Sep 20, 2024 · 0 comments
Labels
💳 technical-debt Issues related to technical debt we introduced

Comments

@lehins
Copy link
Collaborator

lehins commented Sep 20, 2024

Current predicate failure that checks whether withdrawal matches the amount in the reward account is totally misleading. It is reported as WithdrawalsNotInRewardsCERTS, which is also the predicate failure that is used for reporting non-existent reward accounts. We need to create proper predicate failure for that and also fix the name and refactor validateZeroRewards function, cause that is even more misleading.

@lehins lehins added the 💳 technical-debt Issues related to technical debt we introduced label Sep 20, 2024
@lehins lehins mentioned this issue Sep 20, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💳 technical-debt Issues related to technical debt we introduced
Projects
None yet
Development

No branches or pull requests

1 participant