Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for ordinary-index search #265

Closed
jeltsch opened this issue Jun 22, 2024 · 1 comment
Closed

Add tests for ordinary-index search #265

jeltsch opened this issue Jun 22, 2024 · 1 comment
Assignees
Labels
duplicate This issue or pull request already exists enhancement New feature or request wontfix This will not be worked on

Comments

@jeltsch
Copy link
Collaborator

jeltsch commented Jun 22, 2024

We shall add property-based tests for the search function of the ordinary index.

Furthermore, we shall add property-based tests for the binarySearchL function for immutable vectors, which is used by search, in case we haven’t ended up implementing that function by reusing binarySearchL from vector-algorithms.

@jeltsch jeltsch added the enhancement New feature or request label Jun 22, 2024
@jeltsch jeltsch self-assigned this Jun 22, 2024
@jeltsch
Copy link
Collaborator Author

jeltsch commented Sep 1, 2024

Property-based tests for the search function are now available as part of #362.

Property-based tests for the binarySearchL function aren’t necessary, since we have ended up implementing this function by reusing binarySearchL from vector-algorithms (see #256).

@jeltsch jeltsch closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2024
@jeltsch jeltsch added duplicate This issue or pull request already exists wontfix This will not be worked on labels Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant