Use NOINLINE on stringToBuiltinByteString and stringToBuiltinString #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
reviewed
Sep 19, 2024
Unisay
approved these changes
Sep 19, 2024
zliu41
commented
Sep 19, 2024
There was a problem hiding this comment.
I can't really sign off on these changes, because I don't really understand all the moving parts. But I don't mind this getting merged (once comments are addressed).
Ok, I'll merge it. The plugin 100% does not need and cannot compile the unfoldings of stringToBuiltinByteString and stringToBuiltinString, so there's no reason not to mark the OPAQUE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin does not need their unfoldings, and cannot process their unfoldings: neither can the plugin handle
Text.pack, nor does it have a handler forobfuscatedId.Thus
obfuscatedIdmakes no sense whatsoever. And there is no benefit toMagic.noInlinecompared toNOINLINE.