Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at_midBlock.w is always 0 on 1.8.0 betas #2474

Open
ASaull opened this issue Sep 18, 2024 · 0 comments
Open

at_midBlock.w is always 0 on 1.8.0 betas #2474

ASaull opened this issue Sep 18, 2024 · 0 comments
Labels
bug Something is implemented incorrectly

Comments

@ASaull
Copy link

ASaull commented Sep 18, 2024

What happened?

at_midBlock.w seems to always return 0 even though the BLOCK_EMISSION_ATTRIBUTE feature flag is still set.

This is used by Bliss Shaders to add the light from light blocks when using Flood Fill, and no longer works as of the 1.8.0 beta builds.

Light blocks do work in Photon shaders, however, since Photon uses the vanilla lightmap to add the light from light blocks.

Screenshots

1.8.0 Beta 4 (and I also tested Beta 1, same issue)
2024-09-18_00 38 36
1.7.3
2024-09-18_00 40 39

Log output

No response

Minecraft Version

1.21.1

Iris Version

1.8.0-beta.4+1.21-fabric.jar

Operating System

Windows 11

What is your GPU?

RTX 3070

Additional context

This is the relevant section of Bliss Shader code.

	voxelId = uint(mc_Entity.x + 0.5);

	#ifdef IRIS_FEATURE_BLOCK_EMISSION_ATTRIBUTE
		if (voxelId == 0u && at_midBlock.w > 0) voxelId = uint(BLOCK_LIGHT_1 + at_midBlock.w - 1);
	#endif

	if (voxelId == 0u) voxelId = 1u;

	originPos += at_midBlock.xyz/64.0;

at_midblock.xyz works as expected, but at_midblock.w is always 0.

@ASaull ASaull added the bug Something is implemented incorrectly label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is implemented incorrectly
Projects
None yet
Development

No branches or pull requests

1 participant