Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Missing Media" views (Open Meeting Mar 2024) #139

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Mar 29, 2024

Following the "Views" session at the March 2024 open meeting, we realized the Missing Media views were missing filenames in the Data exports, as well they did not use batch processing (but should for scaling).

This PR adds those. And also a missing pager.

Thanks @aOelschlager and team (sorry I forgot who else was in the room and contributing!)

@aOelschlager aOelschlager self-requested a review April 3, 2024 17:31
Copy link
Contributor

Suggested edit:

diff --git a/config/sync/views.view.missing_media.yml b/config/sync/views.view.missing_media.yml
index 5e49835..74f0a2e 100644
--- a/config/sync/views.view.missing_media.yml
+++ b/config/sync/views.view.missing_media.yml
@@ -1120,10 +1120,9 @@ display:
           separator: ', '
           field_api_classes: false
       pager:
-        type: some
+        type: none
         options:
           offset: 0
-          items_per_page: 0
       filters:
         islandora_has_media:
           id: islandora_has_media

@aOelschlager
Copy link
Contributor

Sorry @rosiel I couldn't get the merge to work in the workspace so I had to use the suggested edit thing instead.

Co-authored-by:  Annie Oelschlager <[email protected]>
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the view and all the displays and csv exports and it works! Thanks Rosie!

@aOelschlager aOelschlager merged commit 1c59db0 into main Apr 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants