Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citation feature #50

Merged
merged 7 commits into from
Feb 23, 2023

Conversation

Natkeeran
Copy link
Contributor

@Natkeeran Natkeeran commented Feb 1, 2023

(Not sure if this is the best way to get changes in.)

This PR adds a module called citation_select, which enables one to generate citations using various CSL profiles. It uses the core bibcite module at the backend to generate the citations. It can handle Typed Relation fields as well as EDTF fields.

Essentially, this is adding two new modules

        "drupal/bibcite": "^2.0@beta",
        "drupal/citation_select": "^1.0@beta",

and two additional configs:
config/sync/citation_select.settings.yml
config/sync/context.context.citation_select_block.yml

I waw running into php 8 related build issue in isle-dc, and ran this as suggested by Don, which made some additional changes to the composer.

composer require drupal/search_api_solr:* symfony/string:5.4 maennchen/zipstream-php:2.2.6

Further, the config sync contains some bibcite related configs.

@rosiel
Copy link
Contributor

rosiel commented Feb 23, 2023

I think this is almost ready to go. However the changes I provided to the Citation Select module (renaming the menu links) are on a commit on the 1.0.x branch of Citation Select, and not on the tag 1.0.x-beta2. We currently require @beta, which is better than requiring the head of a branch, so perhaps another beta can be tagged on the citation_select module and we can update the composer.lock file here so that when we merge this PR it comes with the new UI wording.

@rosiel rosiel merged commit 02d6049 into Islandora-Devops:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants