Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependent on islandora_install_profile_demo_core instead of vice-versa #2

Open
bondjimbond opened this issue Jun 21, 2021 · 1 comment

Comments

@bondjimbond
Copy link

This theme is dependent on an install profile, and cannot be extricated from it.

There are four places where a dependency is stated:

  • block.block.islandora_starter_theme_branding.yml
  • block.block.islandora_starter_theme_breadcrumbs.yml
  • block.block.islandora_starter_theme_content.yml
  • block.block.islandora_starter_theme_sitebranding.yml

There seem to be some functions the theme requires that are in the install profile. These should be refactored so that they're in the theme instead.

@Greg-Boggs
Copy link

I too had this issue. I went a step farther and tried to install the demo profile so I could see this theme in action, and I got these errors:

Islandora-Devops/islandora_install_profile_demo#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants